Notices
ECU Flash

Links to jcsbanks' Speed Density patches

Thread Tools
 
Search this Thread
 
Old Jun 2, 2009 | 12:35 PM
  #91  
l2r99gst's Avatar
Evolved Member
iTrader: (2)
 
Joined: Mar 2004
Posts: 3,499
Likes: 4
From: CA
Originally Posted by logic
Eric, just FYI: I almost have the DMA/live-mapping stuff ported to 96530706, just need to check a couple of additional things and test it on my car.

The live map XML will need to change to accommodate the change of addresses for the alt maps (38B00 is now 37B00), and we no longer have low-octane maps to mess around with (although I don't think that was ever exposed in John's application anyway), but overall it's a pretty straightforward set of changes.

I'll hopefully have something worth posting this afternoon or tonight. If you're in a hurry, let me know, and I can email you what I currently have.
Well, if you have it ported over, then that's good...something I don't have to mess with. All I need to do is add my RAM Mut table and any other maps to RAM.

Also, fyi, John posted the latest livemap exe that includes ms in the logging. I have tested that and it's working fine.
Old Jun 2, 2009 | 12:39 PM
  #92  
joedr's Avatar
EvoM Moderator
iTrader: (27)
 
Joined: Feb 2006
Posts: 792
Likes: 2
From: Puerto Rico
Thumbs up

Originally Posted by RoadSpike
Really since the normal 1:1 ratio didn't work for me I just did a trail and error method until i stumbled onto a kind of mantra. I discovered for my setup that around 120 kpa was around 100 load and from then on up it was a 1:1 load to kpa.

For below those points the kpa to load seemed to curve downward 100 kPa was around 87 load, 60 kPa around 55 load, 40 kpa around 28 load, and so on slipping to 0 by 17 kPa.

I suppose this was more a result of the formula for using a 5 bar map sensor than anything but i'm unsure . In any case once i got my AFR reasonably close to 14.7 I would then adjust the VE to make the final jump to 14.7 AFR, i think i ended up with 85-88% at idle.

I think that I get it now! You are comparing the load versus your MAP output in kpa. Right?

In some areas, it becomes linear but on others the correlation is kinda skewed as expected.

Do you mind sharing the final tables for reference?

Thanks in advanced!
Old Jun 2, 2009 | 12:40 PM
  #93  
RoadSpike's Avatar
Evolved Member
iTrader: (5)
 
Joined: Oct 2006
Posts: 3,805
Likes: 2
From: Sacramento, CA
Sure here are my tables from another post

Old Jun 2, 2009 | 01:59 PM
  #94  
logic's Avatar
Evolved Member
iTrader: (2)
 
Joined: Apr 2003
Posts: 1,022
Likes: 6
From: Berkeley, CA
Originally Posted by l2r99gst
Also, fyi, John posted the latest livemap exe that includes ms in the logging. I have tested that and it's working fine.
I'll have to give it a spin; did he include source with the new version? (I seem to recall there was some problem with the charting stuff and redistribution.) If there's no source, I'll have to hack that into the (old) version I'm using, since his builds don't play nicely with small (800x600) displays. It was a bummer realizing that the swanky new HP/TQ estimator didn't work with my old 1-second-resolution logs.

Testing of DMA logging at lunch was a wash; no normal functionality broke, but the ECU reboots whenever the client initiates a DMA connection init. I fat-fingered at least tephra's DEAD address, so there's probably at least a couple of other typos staring at me right now.
Old Jun 2, 2009 | 02:47 PM
  #95  
l2r99gst's Avatar
Evolved Member
iTrader: (2)
 
Joined: Mar 2004
Posts: 3,499
Likes: 4
From: CA
Yes, John included the source code. I think it's in the 96530006 livemap thread, towards the end.
Old Jun 3, 2009 | 10:53 AM
  #96  
logic's Avatar
Evolved Member
iTrader: (2)
 
Joined: Apr 2003
Posts: 1,022
Likes: 6
From: Berkeley, CA
Okay, it's still randomly rebooting on me during comm initialization (MUT logging still works fine, and everything else looks peachy; I'm still impressed at how low-impact this addition is). Here's what I've changed in 96530706 to add John's DMA code, for anyone else who might want to peek at this as well:

Interrupt handlers:
  • 0x138: DMAC3 DEI3 vector changed from 0x9c84 to 0xed10.
  • 0x324: SCI0 RXI0 vector changed from 0xd5d4 to 0x3ec000 (location of John's new code).
DMA-interruption code changes:
  • 0xd46e: Changed "tst #1, r0" (c8 01 8b) to "cmp/eq #0x37, r0" (88 37 89).
  • 0xd6dc: Changed 0xffffeccc reference to 0xffff8480 (DMAOPFLAG).
  • 0xdc26: Changed "mov.b r0, @r10" (2a 00) to "nop" (00 09).
  • 0xe9e6: Changed "mov.l r10, @r11"(2b a2) to "nop" (00 09).
Entry-point adjustment:
  • 0xefac: Changed 0x3e000 (tephra's entry point) to 0x3eeb0 (John's entry point).
New code:
  • Copy John's chunk of code at 3ec00 through 3ef5f. I've actually gone to the trouble of re-assembling this now, and the assembled version matches what I ended up with through hex editing. Go figure. If you don't re-assemble his source, you need to make the following changes:
  • 0x3ef18: Changed 0xffffa800 to 0xffff841e (tephra's DEAD address).
  • 0x3ef30: Changed 0x3f000 to 0x3e000 (tephra's entry point).
  • 0x3ef34: Changed 0x38b00 to 0x37b00 (new start of alt-map location).
Tephra adjustments:
  • 0x3e1d4: Changed 0xffff8984 reference to 0xffff898a (this is a WTF for me, but it was changed in John's version of 96530006).
  • 0x3e640: Changed 0xffff841c reference to 0xffffa800 (another WTF, same thing).
Alt-map relocation to RAM:
  • 0x3e7d4: Changed 0x37b40 to 0xffffa040 (alt injector scaling). This isn't strictly necessary, since I don't think the client actually supports scaling adjustments right now, does it? (Anyone want to write a feedback-driven injector latency and scaling tuning tool using this? )
  • 0x3e7dc: Changed 0x37b42 to 0xffffa042 (alt high-octane fuel).
  • 0x3e7e8: Changed 0x37c82 to 0xffffa182 (alt high-octane timing).
  • 0x3e7f4: Changed 0x37e42 to 0xffffa342 (alt BWGDC).
  • 0x3e7fc: Changed 0x37ec2 to 0xffffa3c2 (alt BDEL).
Other stuff:
  • MUT0 (or something similar) should probably be changed to 1-byte load.
  • In the client, address.xml needs to be changed so that the high-octane timing map is at a182, rather than a2cd.
  • In the client, blockaddress.xml needs to be changed so that the "ROM address" is at 0x37b0, not 0x038b0.
I've attached the assembly source I'm working with, if anyone wants to see it. (It's not much different from what John originally posted, just reformatted a bit so the binutils sh assembler likes it.) I'm not providing a pre-patched ROM for obvious reasons right now. jcsbanks, l2r99gst, mrfred, tephra, or anyone else who feels like taking a peek at this, can you see anything obvious that I've missed? I'm particularly curious about the changes to those two locations in tephra's code; I haven't dug into what's happening there enough to know why he changed that.
Attached Files
File Type: txt
src.txt (8.8 KB, 0 views)
Old Jun 3, 2009 | 11:51 AM
  #97  
l2r99gst's Avatar
Evolved Member
iTrader: (2)
 
Joined: Mar 2004
Posts: 3,499
Likes: 4
From: CA
Originally Posted by logic
Alt-map relocation to RAM:
  • 0x3e7d4: Changed 0x37b40 to 0xffffa040 (alt injector scaling). This isn't strictly necessary, since I don't think the client actually supports scaling adjustments right now, does it? (Anyone want to write a feedback-driven injector latency and scaling tuning tool using this? )
  • 0x3e7dc: Changed 0x37b42 to 0xffffa042 (alt high-octane fuel).
  • 0x3e7e8: Changed 0x37c82 to 0xffffa182 (alt high-octane timing).
  • 0x3e7f4: Changed 0x37e42 to 0xffffa342 (alt BWGDC).
  • 0x3e7fc: Changed 0x37ec2 to 0xffffa3c2 (alt BDEL).
Where is this being done in the v5.1 dma-livemap ROM? I am looking at that in IDA Pro, but don't seem to see it. I thought John just copied this whole block to RAM and didn't think the alt maps in this location needed to be explicitly pointed to RAM.

I know if you want to copy another map to RAM, like injector latency, then you have to change the pointer to the RAM address based on where it is copied to that block, though. I just asked John that question actually.

Of course, I'm not that good with this stuff, so if this was a dumb question, feel free to let me know.

Last edited by l2r99gst; Jun 3, 2009 at 01:12 PM.
Old Jun 3, 2009 | 12:45 PM
  #98  
logic's Avatar
Evolved Member
iTrader: (2)
 
Joined: Apr 2003
Posts: 1,022
Likes: 6
From: Berkeley, CA
In 96530006, those changes were at:
  • 0x3f650 (injector scaling)
  • 0x3f654 (high-octane fuel)
  • 0x3f65c (low-octane fuel)
  • 0x3f664 (high-octane timing)
  • 0x3f66c (low-octane timing)
  • 0x3f674 (BWGDC)
  • 0x3f67c (BDEL)
He copies that block of ROM to RAM, but then you still have to fix up any individual references. The addresses change a bit from v5.10 to v7, because we lost the low-octane maps.

If you're wondering how I found that, I just did a diff against a hexdump of a stock v5.10 vs. John's version, and walked through the list of changes to see which was which. That's where I found the two WTFs in my list above.

Last edited by logic; Jun 4, 2009 at 09:23 PM.
Old Jun 3, 2009 | 12:57 PM
  #99  
l2r99gst's Avatar
Evolved Member
iTrader: (2)
 
Joined: Mar 2004
Posts: 3,499
Likes: 4
From: CA
Thanks. I never did the hex compare yet. That's what I was going to do to compare John's changes, but he said he was going to send me an XML with just the livemap/DMA changes, so I never got around to that yet.

If I have some time, I will try to walk through what you have done to see if I can see anything obvious. I doubt I will, but sometimes I surpirse myself, but for the most part I'm just dangerous enough to mess around with the ROM in IDA.

I have to fix my damn omni power sensor first, since I got one of the 'bad' ones where the sensor plug wires need to be switched.

Edit: you mean alt injector scaling, not latency.

Last edited by l2r99gst; Jun 3, 2009 at 01:10 PM.
Old Jun 4, 2009 | 02:33 PM
  #100  
logic's Avatar
Evolved Member
iTrader: (2)
 
Joined: Apr 2003
Posts: 1,022
Likes: 6
From: Berkeley, CA
Well, I never did get this working; E0 seems to be the cause of the random reboots. I'm out of time to look at any of this until next Tuesday, as I'm out of the country, so if someone else wants to pick up where I left off, you won't be duplicating effort.

And it occurs to me that I shouldn't be clogging up mrfred's thread about speed density with this, should I?
Old Jun 4, 2009 | 06:10 PM
  #101  
golruss's Avatar
Evolving Member
iTrader: (3)
 
Joined: May 2005
Posts: 233
Likes: 2
From: Fuquay Varina NC
Originally Posted by l2r99gst
Well, if you have it ported over, then that's good...something I don't have to mess with. All I need to do is add my RAM Mut table and any other maps to RAM.

Also, fyi, John posted the latest livemap exe that includes ms in the logging. I have tested that and it's working fine.
Have you tried Mr Freds patch for SD yet, if so how is it working?
Ray
Old Jun 4, 2009 | 06:38 PM
  #102  
mrfred's Avatar
Thread Starter
EvoM Guru
iTrader: (50)
 
Joined: Mar 2006
Posts: 9,675
Likes: 130
From: Tri-Cities, WA // Portland, OR
Originally Posted by golruss
Have you tried Mr Freds patch for SD yet, if so how is it working?
Ray
I've been very busy at work. I'm sending him a patched ROM this evening to try.
Old Jun 4, 2009 | 06:44 PM
  #103  
golruss's Avatar
Evolving Member
iTrader: (3)
 
Joined: May 2005
Posts: 233
Likes: 2
From: Fuquay Varina NC
Originally Posted by mrfred
I've been very busy at work. I'm sending him a patched ROM this evening to try.
Great!!!! thanks for all your hard work.
Old Jun 4, 2009 | 06:46 PM
  #104  
l2r99gst's Avatar
Evolved Member
iTrader: (2)
 
Joined: Mar 2004
Posts: 3,499
Likes: 4
From: CA
No rush, mrfred. I won't be able to test until the weekend anyway. If I get a ROM by then, I will be happy to test it out.

I will be out of town mid-week until the next week, so if the ROM isn't ready by then, feel free to send to another eager tester.


Eric
Old Jun 4, 2009 | 07:16 PM
  #105  
tom04841's Avatar
Newbie
 
Joined: Jan 2009
Posts: 47
Likes: 0
From: maine
I will gladly test a tephra v5.10 version of this rom if you'd like to email it to me or pm me a link. My email is tom04841@gmail.com



All times are GMT -7. The time now is 10:12 PM.